Best way to file pull requests

Dear all,

I have some smaller and larger extensions to incorporate into LAMMPS. Since the preferred way to do this is by using Git, I want to do it that way as well, but I have on question: Which branch should I fork on GitHub, the master or LAMMPS-ICMS?

I don’t know if it already exists, but if not, I could write up a short tutorial, maybe that would be helpful to put on the website for in the future?

Dear all,

I have some smaller and larger extensions to incorporate into LAMMPS. Since
the preferred way to do this is by using Git, I want to do it that way as
well, but I have on question: Which branch should I fork on GitHub, the
master or LAMMPS-ICMS?

please use/fork the lammps-icms branch.

pull requests currently are always merged into lammps-icms first and
then reviewed and checked for integration issues, portability issue
and steve-compatibility. :wink:

if you fork from master the consequence is primarily that github (or
bitbucket) doesn't automatically notice that the branch was merged.
also, your pull request is not automatically tested on travis-ci
immediately when posting the pull request.

for me to merge the request is about the same effort unless you have
changes where lammps-icms diverges from master, which is currently in
very few places. both branches are very close since the last
synchronization and will be even closer soon.

I don't know if it already exists, but if not, I could write up a short
tutorial, maybe that would be helpful to put on the website for in the
future?

certainly. i am certain that people will appreciate it. i am very much
in favor of including changes via pull requests, as it makes the whole
process more transparent. the more people are going this route, the
better the chances that at some point LAMMPS will get rid of
subversion and its quirks and complications.

axel.