Fetching of atom tags correct in granular pairstyles?

Dear LAMMPS users,

A few weeks ago, the line used to retrieve atom tags changed from

int *tag = atom->tag;

to

tagint *tag = atom->tag;

This change was made widely, in computes, dumps, fixes, etc. However this alteration has not been made in the ‘single’ functions of the granular pairstyles (GRANULAR/pair_gran_*.cpp) and I think that perhaps these should be changed similarly.

Regards,

Kevin Hanley

Post-doctoral researcher
Dept. of Civil and Environmental Engineering
Imperial College London, SW7 2AZ

Dear LAMMPS users,

A few weeks ago, the line used to retrieve atom tags changed from

int *tag = atom->tag;

to

tagint *tag = atom->tag;

This change was made widely, in computes, dumps, fixes, etc. However this
alteration has not been made in the 'single' functions of the granular
pairstyles (GRANULAR/pair_gran_*.cpp) and I think that perhaps these should
be changed similarly.

kevin,

can you please point out where the changes would be needed. i don't
see it and i can compile LAMMPS with -DLAMMPS_BIGBIG with the granular
package included and if there were some missing changes, it would
result in a compilation error. also, unless you use an executable with
that flag used, code should compile and work correctly, even without
any int/tagint updates.

thanks,

axel.

Hi Axel,

I've checked again and you're correct. My mistake - the atom tags aren't used anywhere in the granular pairstyles. I added them myself for test purposes. Sorry about the confusion,

Kevin

Hi Axel,

I've checked again and you're correct. My mistake - the atom tags aren't used anywhere in the granular pairstyles. I added them myself for test purposes. Sorry about the confusion,

no problem. i'd rather have someone err on the side of caution than
know about a problem and not report it (but just work around it).

there are ongoing efforts to increase the overall consistency and code
quality in LAMMPS and implement more integration testing for any
changes. so any extra set of eyes that check out changes is highly
welcome.

thanks,
     axel.