force_clear() in Verlet and Respa classes

LAMMPS LAMMPS Mailing List Mirror
1

Hello list,
I’m trying to understand why there are separate implementations of the force_clear() method in the Verlet and Respa classes. The method in Verlet seems to be more powerful (using memset if group ‘all’ is being integrated).
Wouldn’t it make sense to have force_clear() be a method of the Integrate base class?
Daniel

P.S.: I’m asking as I’m working on a proxy pair style that needs to clear forces. And as it currently is I have to duplicate code.

2

It probably could be moved into the base class, though the 2 versions
are different at the moment, due to the includegroup logic.

Axel, there is a comm->nthreads setting used for clearing arrays in
Respa:force_clear() - is that out-of-date? It's not in Verlet.

Steve