I fix the sph-multiphase + some extra question

Hi all,

During my google-fu weeks of desperation, I came across a multiphase implementation for LAMMPS/USER-SPH (yay!). Yet I didn’t realise it was about 3 years old (nay…) so I spent about 3 days trying to fix it (due to mainly my inexperience… looking back what I have done should only be 30 minutes max… I paid a huge stupidity tax here).

I have the code compiling and working here at https://github.com/quang-ha/lammps which was inherited mainly from https://github.com/slitvinov/lammps-sph-multiphase. While yes it works for me, I know that it would be great if I can contribute to the documentation of USER-SPH to help other users as well. This brings me to two questions:

  1. Say if I want to merge my fork to the main git, should I fix up something? There should be a lot of code-style/file structures that you guys want to stick to.

  2. Does anyone have some form of documentation for the examples in the multiphase code? Running the LAMMPS code give me some form of bubble nucleation and bubble formation on wall. While the gif and video is really cool (BOO YA!!!) I struggle to understand the equation behind the scene (boo nah…). Any seasoned USER-SPH could kindly provide me toward some good direction? Even something as trivial as “How you go from SPH formulation to LAMMPS code”? (yes this question is something for me to figure out I believe so, but I have been getting to the depressing zone and some enlightenment would save this poor soul from committing sudoku.)

Many thanks,
QT

Hi all,

During my google-fu weeks of desperation, I came across a multiphase
implementation for LAMMPS/USER-SPH (yay!). Yet I didn't realise it was about
3 years old (nay...) so I spent about 3 days trying to fix it (due to mainly
my inexperience... looking back what I have done should only be 30 minutes
max... I paid a huge stupidity tax here).

I have the code compiling and working here at
GitHub - quang-ha/lammps: Public development project of the LAMMPS MD software package which was inherited mainly from
GitHub - slitvinov/lammps-sph-multiphase: Multiphase SPH simulation with evaporation. While yes it works for
me, I know that it would be great if I can contribute to the documentation
of USER-SPH to help other users as well. This brings me to two questions:

1) Say if I want to merge my fork to the main git, should I fix up
something? There should be a lot of code-style/file structures that you guys
want to stick to.

before even going there, i would suggest you contact the author of the
USER-SPH package. he is the primary maintainer of that package and
should approve of the changes you want to include. his name and e-mail
should be in a README file in the USER-SPH folder.

axel.