Variable find const char

LAMMPS LAMMPS Mailing List Mirror
1

Hello Lammps-users,

Just a small thing, the Variable::find(char*) function should take a (const char*) instead. I noticed this when adding the ability to use "v_" variables to a fix that uses a std::string to store the variable name, then calls input->variable->find(varname.c_str()), which currently doesn't work without const_cast.

I don't think the change the find() parameter to const will break anything, since it only calls strcmp().

2

A lot of methods in LAMMPS could take const char *,
but I rarely use them.

Since you are writing the caller code, you can simply cast
it yourself: input->variable->find((char *) varname.c_str())
and it should work fine.

Note that if you'd like your upgraded fix to be added to
main LAMMPS, you shouldn't use std::char. Nothing
in LAMMPS uses std (that I can recall), and I'd like
to keep it that way.

Steve