A minor indexing bug in dump_image.cpp

LAMMPS LAMMPS Development
1

Dear Axel,

I recently found a minor index bug in dump_image.cpp, more specifically, 29Aug2024 version, line 890. I attached a screenshot here.

image
image1004×650 52.5 KB

In the highlighted line, I believe the index should be j, not i. Indeed, this line of code will cause rendering error if there are several kinds of body particles. After replacing “body[i]” with “body[j]”, the rendering works correctly. I can provide a simple test input file to reproduce this bug if you are interested. I was wondering if it worths to open a issue on github to report and fix it. I never did this before and I think this is a good process to learn.

2

Indeed, if you want to learn the process, this is a good opportunity. But it is not necessary to submit both, a bug report issue and a pull request. Only one of the two will suffice.

4

Thank you Axel, I just created a pull request on github. Not sure my summary message reads clear, but I have attached a full package for reproducing this bug.

5

Hi Axel, I have an irrelevant question. Are you using git cherry-pick to merge the commit into other branches?

6

For simple cases like this one, yes.
It depends on how much the branches have diverged.

1 Like