comparison between latest svn version and tarball version

Hi All

I compared latest svn version and latest tarball version and i found our several differences. I have attached them in the file herewith.

Best
Chetan

difflmp (42.1 KB)

Hi All

I compared latest svn version and latest tarball version and i found our
several differences. I have attached them in the file herewith.

chetan,

as i explained already,

the svn tree is up to 24 hours behind.
you cannot expect that a patch that was
published today is already included.

however, the line that you are missing in run.cpp _is_
present in the svn. are you sure you have not accidentally
deleted it on your checkout. perhaps top please a certain compiler?

axel.

Hi All

I compared latest svn version and latest tarball version and i found our
several differences. I have attached them in the file herewith.

chetan,

as i explained already,

the svn tree is up to 24 hours behind.
you cannot expect that a patch that was
published today is already included.

however, the line that you are missing in run.cpp _is_
present in the svn. are you sure you have not accidentally
deleted it on your checkout. perhaps top please a certain compiler?

this seems even more plausible, since your checkout
_also_ has code related to ATOBIGINT() commented out
in update.cpp.

have you tried running: svn diff
to see, if you have local modifications to your code?

you can fix this easily by deleting run.cpp and update.cpp
and then doing another svn update to restore the original versions.

...and then i recommend to ditch the stupid PGI compiler and
change to a more reasonable one.

cheers,
   axel.

Thanks, Axel. So i downloaded a new working copy of the svn repo and that error from run.cpp has disappeared (don’t know why it was coming earlier), but new errors are coming now (I do have fftw loaded):

mpicxx -O -DFFT_FFTW -I/include -c fft3d.cpp
In file included from fft3d.cpp:22:
fft3d.h:164:18: error: fftw.h: No such file or directory
In file included from fft3d.cpp:22:
fft3d.h:165: error: ‘FFTW_COMPLEX’ does not name a type
fft3d.h:186: error: ISO C++ forbids declaration of ‘FFT_DATA’ with no type
fft3d.h:186: error: expected ‘;’ before ‘’ token
fft3d.h:187: error: ISO C++ forbids declaration of ‘FFT_DATA’ with no type
fft3d.h:187: error: expected ‘;’ before '
’ token
fft3d.h:224: error: ‘fftw_plan’ does not name a type
fft3d.h:225: error: ‘fftw_plan’ does not name a type
fft3d.h:226: error: ‘fftw_plan’ does not name a type
fft3d.h:227: error: ‘fftw_plan’ does not name a type
fft3d.h:228: error: ‘fftw_plan’ does not name a type
fft3d.h:229: error: ‘fftw_plan’ does not name a type
fft3d.h:235: error: variable or field ‘fft_3d’ declared void
fft3d.h:235: error: ‘FFT_DATA’ was not declared in this scope
fft3d.h:235: error: expected primary-expression before ‘,’ token
fft3d.h:235: error: ‘FFT_DATA’ was not declared in this scope
fft3d.h:235: error: expected primary-expression before ‘,’ token
fft3d.h:235: error: expected primary-expression before ‘int’
fft3d.h:235: error: expected primary-expression before ‘struct’
fft3d.h:242: error: variable or field ‘fft_1d_only’ declared void
fft3d.h:242: error: ‘FFT_DATA’ was not declared in this scope
fft3d.h:242: error: expected primary-expression before ‘,’ token
fft3d.h:242: error: expected primary-expression before ‘int’
fft3d.h:242: error: expected primary-expression before ‘int’
fft3d.h:242: error: expected primary-expression before ‘struct’
fft3d.cpp:58: error: variable or field ‘fft_3d’ declared void
fft3d.cpp:58: error: ‘FFT_DATA’ was not declared in this scope
fft3d.cpp:58: error: ‘in’ was not declared in this scope
fft3d.cpp:58: error: ‘FFT_DATA’ was not declared in this scope
fft3d.cpp:58: error: ‘out’ was not declared in this scope
fft3d.cpp:58: error: expected primary-expression before ‘int’
fft3d.cpp:58: error: expected primary-expression before ‘struct’
make[1]: [fft3d.o] Error 1 (ignored)
mpicxx -O -DFFT_FFTW -I/include -c fft3d_wrap.cpp
In file included from fft3d_wrap.h:18,
from fft3d_wrap.cpp:15:
fft3d.h:164:18: error: fftw.h: No such file or directory
In file included from fft3d_wrap.h:18,
from fft3d_wrap.cpp:15:
fft3d.h:165: error: ‘FFTW_COMPLEX’ does not name a type
fft3d.h:186: error: ISO C++ forbids declaration of ‘FFT_DATA’ with no type
fft3d.h:186: error: expected ‘;’ before ‘’ token
fft3d.h:187: error: ISO C++ forbids declaration of ‘FFT_DATA’ with no type
fft3d.h:187: error: expected ‘;’ before '
’ token
fft3d.h:224: error: ‘fftw_plan’ does not name a type
fft3d.h:225: error: ‘fftw_plan’ does not name a type
fft3d.h:226: error: ‘fftw_plan’ does not name a type
fft3d.h:227: error: ‘fftw_plan’ does not name a type
fft3d.h:228: error: ‘fftw_plan’ does not name a type
fft3d.h:229: error: ‘fftw_plan’ does not name a type
fft3d.h:235: error: variable or field ‘fft_3d’ declared void
fft3d.h:235: error: ‘FFT_DATA’ was not declared in this scope
fft3d.h:235: error: expected primary-expression before ‘,’ token
fft3d.h:235: error: ‘FFT_DATA’ was not declared in this scope
fft3d.h:235: error: expected primary-expression before ‘,’ token
fft3d.h:235: error: expected primary-expression before ‘int’
fft3d.h:235: error: expected primary-expression before ‘struct’
fft3d.h:242: error: variable or field ‘fft_1d_only’ declared void
fft3d.h:242: error: ‘FFT_DATA’ was not declared in this scope
fft3d.h:242: error: expected primary-expression before ‘,’ token
fft3d.h:242: error: expected primary-expression before ‘int’
fft3d.h:242: error: expected primary-expression before ‘int’
fft3d.h:242: error: expected primary-expression before ‘struct’
fft3d_wrap.cpp: In member function ‘void LAMMPS_NS::FFT3d::compute(double*, double*, int)’:
fft3d_wrap.cpp:47: error: ‘FFT_DATA’ was not declared in this scope
fft3d_wrap.cpp:47: error: expected primary-expression before ‘)’ token
fft3d_wrap.cpp:47: error: expected primary-expression before ‘)’ token
fft3d_wrap.cpp:47: error: ‘fft_3d’ was not declared in this scope
fft3d_wrap.cpp: In member function ‘void LAMMPS_NS::FFT3d::timing1d(double*, int, int)’:
fft3d_wrap.cpp:54: error: ‘FFT_DATA’ was not declared in this scope
fft3d_wrap.cpp:54: error: expected primary-expression before ‘)’ token
fft3d_wrap.cpp:54: error: ‘fft_1d_only’ was not declared in this scope
make[1]: [fft3d_wrap.o] Error 1 (ignored)

Any leads?

THanks
Chetan

Thanks, Axel. So i downloaded a new working copy of the svn repo and that
error from run.cpp has disappeared (don't know why it was coming earlier),

i have a pretty good idea what happened. :wink:

but new errors are coming now (I do have fftw loaded):

yes, but you makefile is wrong!

mpicxx -O -DFFT_FFTW -I/include -c fft3d.cpp

check out the -I flag. there is a path missing.

In file included from fft3d.cpp:22:
fft3d.h:164:18: error: fftw.h: No such file or directory
In file included from fft3d.cpp:22:

[...]

fft3d_wrap.cpp:54: error: 'FFT_DATA' was not declared in this scope
fft3d_wrap.cpp:54: error: expected primary-expression before ')' token
fft3d_wrap.cpp:54: error: 'fft_1d_only' was not declared in this scope
make[1]: [fft3d_wrap.o] Error 1 (ignored)
Any leads?

yes. just check the first error. it cannot find the fftw header.
the rest is just a consequence of it.

axel