PartialsSiteStatsFingerprint request

Matminer
1

Hello all,

I wanted to make a feature request. Just wanted to post here for feedback before opening a pull request.

Specifically, I’d like to add a PartialsSiteStatsFingerprint. Much like there is the RDF and partial-RDF fingerprints (partial = broken down by element pairs), I’d like to have a SiteStats and partial-SiteStats fingerprints (partial = SiteStats broken down by element).

Would anyone be interested helping me add this feature? I have the code outlined but haven’t opened a pull-request yet.

-Jack

2

This ended up being easier to implement than I expected. There may have been things I overlooked, so it will help if maintainers take a look at the pull request.

-Jack

3

Hey @jacksund thanks for the interest! I’ll look over that PR soon

4

Hi @ardunn. Sorry to keep bothering you about this, but I’d like to use this feature in production. Are you able to look over the PR this week?

1 Like