Hello,
I've been working on an update to pair_kim that will allow for its use with hybrid and fix_adapt. In order to git this to work, I needed to make some (minor, I think) changes to the fix_adapt code.
The updated files are attached (based on git-svn-id: svn://svn.icms.temple.edu/lammps-ro/[email protected]... f3b2605a-c512-4ea7-a41b-209d697bcdaa).
I would be grateful if someone knowledgeable about the fix_adapt framework could review these changes and let me know if there are any issues with them and if they can be merged into the main line.
Thanks,
Ryan Elliott
fix_adapt.h (2.91 KB)
fix_adapt.cpp (18.1 KB)
Hello,
hello ryan,
I've been working on an update to pair_kim that will allow for its use with
hybrid and fix_adapt. In order to git this to work, I needed to make some
(minor, I think) changes to the fix_adapt code.
The updated files are attached (based on git-svn-id:
svn://svn.icms.temple.edu/lammps-ro/[email protected]...
f3b2605a-c512-4ea7-a41b-209d697bcdaa).
I would be grateful if someone knowledgeable about the fix_adapt framework
could review these changes and let me know if there are any issues with them
and if they can be merged into the main line.
i'll take a look, merge them with my branch, will check if additional
changes are needed, and will feed them to steve.
FYI, as an alternate approach for having changes like this checked and
reviewed, you can also file a pull request on the github page for
LAMMPS.
https://github.com/lammps/lammps/pulls ...and if you branch off of
the lammps-icms branch, you'll get free integration testing on Travis
CI as a bonus: https://travis-ci.org/lammps/lammps/pull_requests
for small changes like this, it doesn't make much of a difference, but
if you are already working off a git repository, you can simplify the
merge process substantially for more complex change sets.
cheers,
axel.