write_dump error

Hi,

I just updated my source code and was verifying some scripts when I received an error by using the write_dump command. The error message is:

ERROR: Illegal dump custom command (…/dump_custom.cpp:63)

It appears that this line was added as a check for nevery at some point between my updating (about a year ago). I tried a simple hack to comment it out, but that created some nasty warnings and hung up execution.

To reproduce this behavior, I added this line to the end of the in.colloid script:

write_dump all custom dump.myforce.* id type x y z

The error is reproduced in serial or parallel and I also tried using lammps-daily (ubuntu 14.04 reasonably up to date) with same result. The image variant of write_dump gives the same error as well. Any help is appreciated.

-Kurt

Hi,

I just updated my source code and was verifying some scripts when I
received an error by using the write_dump command. The error message is:

ERROR: Illegal dump custom command (../dump_custom.cpp:63)

It appears that this line was added as a check for nevery at some point
between my updating (about a year ago). I tried a simple hack to comment it
out, but that created some nasty warnings and hung up execution.

​yes, this was added by me as part of our ongoing code audit using a
variety of tools to harden LAMMPS against unwarranted crashes and
unexpected behavior.​

To reproduce this behavior, I added this line to the end of the in.colloid
script:

write_dump all custom dump.myforce.* id type x y z

The error is reproduced in serial or parallel and I also tried using
lammps-daily (ubuntu 14.04 reasonably up to date) with same result. The
image variant of write_dump gives the same error as well. Any help is
appreciated.

​​yes, because the bug, in my opinion is in write_dump (which is a bit
embarrassing, since i wrote that, too). it should not set the dump
frequency to zero. so you should add the following change/patch.

diff --git a/src/write_dump.cpp b/src/write_dump.cpp
index f56faa0..a8ad541 100644
--- a/src/write_dump.cpp
+++ b/src/write_dump.cpp
@@ -51,7 +51,7 @@ void WriteDump::command(int narg, char **arg)
   dumpargs[0] = (char *) "WRITE_DUMP"; // dump id
   dumpargs[1] = arg[0]; // group
   dumpargs[2] = arg[1]; // dump style
- dumpargs[3] = (char *) "0"; // dump frequency
+ dumpargs[3] = (char *) "1"; // dump frequency

   for (int i = 2; i < modindex; ++i)
     dumpargs[i+2] = arg[i];

i'll add it to the lammps-icms branch and will forward it to steve at the
next occasion (i.e. when he has recovered from overhauling the
documentation creation system. :wink: ).

thanks for reporting,
      axel.